Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully implement /savefile (except ImportText() because fuck it) #1554

Merged
merged 86 commits into from
Mar 2, 2024
Merged

Fully implement /savefile (except ImportText() because fuck it) #1554

merged 86 commits into from
Mar 2, 2024

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Dec 14, 2023 •
edited
Loading

ExportText(), object reading & writing, calling Read() and Write(). Merged with #1546.

resolves #1303
resolves #1305
resolves #1306

Also fixed a bug with fcopy() where it'd fail if there wasn't a dir prefix like ./

TODO

  • Implement ExportText()
  • ExportText for lists
  • Fix formatting on ExportText()
  • Finish saving objects under the weird ".0" path thing
  • Load objects, calling New() and Read()
  • Save/Load floats & strings
  • Save/Load lists
  • Lists with objects in them
  • Save/Load type paths
  • json serialisation & deserialisation
  • filedata stuff (savefiles & icons)

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Feb 9, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Feb 18, 2024
@wixoaGit wixoaGit mentioned this pull request Mar 1, 2024
Merged
wixoaGit
wixoaGit requested changes Mar 1, 2024
View reviewed changes
OpenDreamRuntime/Objects/Types/DreamList.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Objects/Types/DreamList.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Objects/Types/DreamList.cs Outdated Show resolved Hide resolved
Content.Tests/DMProject/Tests/Savefile/BasicReadAndWrite.dm Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/DMOpcodeHandlers.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeSavefile.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeSavefile.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeSavefile.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeSavefile.cs Outdated Show resolved Hide resolved
OpenDreamRuntime/Procs/Native/DreamProcNativeSavefile.cs Outdated Show resolved Hide resolved
@wixoaGit wixoaGit enabled auto-merge (squash) March 1, 2024 23:54
@wixoaGit wixoaGit merged commit 39f99ac into OpenDreamProject:master Mar 2, 2024
7 checks passed
@amylizzle amylizzle deleted the exporttext branch March 2, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

@LetterN LetterN Awaiting requested review from LetterN

Assignees
No one assigned
Labels
Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/XXL
Projects
None yet
Milestone
No milestone
3 participants
@amylizzle @LetterN @wixoaGit